[ checkstyle-Patches-3044164 ] Update for Maximum Line Length check

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[ checkstyle-Patches-3044164 ] Update for Maximum Line Length check

SourceForge.net
Patches item #3044164, was opened at 2010-08-13 01:16
Message generated for change (Comment added) made by nobody
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=397080&aid=3044164&group_id=29721

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: Later
Priority: 5
Private: No
Submitted By: Ruslan Diachenko (rusya7)
Assigned to: Nobody/Anonymous (nobody)
Summary: Update for Maximum Line Length check

Initial Comment:
Hello, checkstyle developers.

This check is an update for the one that checks maximum line length. It makes exceptions, as options, for:
- class declaration;
- constructor declaration;
- field declaration;
- method declaration.

Reason: to avoid such situation - after using formatter in IDE it formats long field or method declaration and puts it into one string, as a result - warning.
But I can't change formatter due to policy of the company.

The update-patch was created according your requirements, tested by Unit tests, builded by ant.

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2012-08-19 11:27

Message:
hUa4jt  <a href="http://qlixnqfgymsj.com/">qlixnqfgymsj</a>,
[url=http://tvsnnikazyog.com/]tvsnnikazyog[/url],
[link=http://pbbxgejexcde.com/]pbbxgejexcde[/link],
http://izndxdkrqbjb.com/

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2012-04-15 15:24

Message:
xJn2Iy  <a href="http://ulfhuvqppivy.com/">ulfhuvqppivy</a>,
[url=http://fvsbsafijshp.com/]fvsbsafijshp[/url],
[link=http://lkcwistvimad.com/]lkcwistvimad[/link],
http://rdxdrzvjgujc.com/

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2012-01-15 15:20

Message:
O7iBzc  <a href="http://baklwipgrnra.com/">baklwipgrnra</a>,
[url=http://xnjpamsnercf.com/]xnjpamsnercf[/url],
[link=http://suhsifvptssp.com/]suhsifvptssp[/link],
http://ogikbsgwcsly.com/

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2011-11-11 09:26

Message:
qtCqxx  <a href="http://seoibmwfekqq.com/">seoibmwfekqq</a>,
[url=http://zlwobzeaajuo.com/]zlwobzeaajuo[/url],
[link=http://upekphnmbswp.com/]upekphnmbswp[/link],
http://mlpyfiimrplo.com/

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2011-11-11 09:24

Message:
qtCqxx  <a href="http://seoibmwfekqq.com/">seoibmwfekqq</a>,
[url=http://zlwobzeaajuo.com/]zlwobzeaajuo[/url],
[link=http://upekphnmbswp.com/]upekphnmbswp[/link],
http://mlpyfiimrplo.com/

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2011-07-30 17:54

Message:
wAlLx2  <a href="http://fnvnyoegoxqt.com/">fnvnyoegoxqt</a>,
[url=http://zjyohzweemvv.com/]zjyohzweemvv[/url],
[link=http://cwdgxniivlox.com/]cwdgxniivlox[/link],
http://aikcluzqlgms.com/

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2011-06-28 08:29

Message:
bnBR4q  <a href="http://evotetpqgtpf.com/">evotetpqgtpf</a>,
[url=http://cntxxftwuocx.com/]cntxxftwuocx[/url],
[link=http://cokbwyjxkbrc.com/]cokbwyjxkbrc[/link],
http://mkdebsshicng.com/

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2011-06-05 22:56

Message:
4474yD  <a href="http://qzdqcwydmthn.com/">qzdqcwydmthn</a>,
[url=http://ydqbywjecpng.com/]ydqbywjecpng[/url],
[link=http://kpuuoxsdjuqv.com/]kpuuoxsdjuqv[/link],
http://ybmvmfrnqtyq.com/

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2011-04-07 15:49

Message:
AQG5S7  <a href="http://gbbgcruzmofi.com/">gbbgcruzmofi</a>,
[url=http://adwfqdkrmiuw.com/]adwfqdkrmiuw[/url],
[link=http://pgndbgcvstwt.com/]pgndbgcvstwt[/link],
http://wklxetkwrxek.com/

----------------------------------------------------------------------

Comment By: Vladimir Lifar (lifarv)
Date: 2010-10-25 12:33

Message:
Great feature! Absence of workarounds is a weak point of CheckStyle.
Sometimes we need to disable checks because they conflicts with eclipse's
formatter. I consider such options should be done for all checks, which
conflicts with standard IDE behaviour.

----------------------------------------------------------------------

Comment By: Oliver Burn (oburn)
Date: 2010-10-17 04:19

Message:
Let me think about it some more.

----------------------------------------------------------------------

Comment By: Ruslan Diachenko (rusya7)
Date: 2010-10-12 04:55

Message:
There are some reasons that this check will be useful for –°heckstyle
users:

- one of the main reason is that users can smoothly and gradually adopt
Checkstyle code control to their existing huge projects;

- in a majority of companies users can't change their formatters simply to
comply with a Maximum Line Length check;

- the formatter is used for a long time and a Checkstyle is a rather new
project for some companies;

- it's easier to turn on some check's options and make sure that Checkstyle
is worth using, and after checkstyle robation time reconfigurate a
formatter if it is possible;

- applying a check to the large project brings users a lot of warnings, so
it is useful when check has some additional options to turn some of them
off and to refactor a code gradually from simple to the difficult.

----------------------------------------------------------------------

Comment By: Oliver Burn (oburn)
Date: 2010-10-07 03:59

Message:
This seems to be a workaround for buggy formatter. I do not believe the
complexity this check adds is worth the benefit it would bring to the vast
majority of users.

I will leave this patch open for comments if other people want to
disagree.


----------------------------------------------------------------------

Comment By: Roman Ivanov (romanivanov)
Date: 2010-08-14 00:19

Message:
This check was tested over source code of Reveredata - works fine. These
options smooth our migration to Checkstyle code control. Additional thanks
for corresponding update of Eclipse plugin.

----------------------------------------------------------------------

Comment By: Ruslan Diachenko (rusya7)
Date: 2010-08-13 06:02

Message:
CVS patch for Eclipse was created. You can find it following next link:

https://sourceforge.net/tracker/?func=detail&aid=3044313&group_id=80344&atid=559496

----------------------------------------------------------------------

Comment By: Ruslan Diachenko (rusya7)
Date: 2010-08-13 04:35

Message:
Default xml configuration:

<?xml version="1.0"?>
<!DOCTYPE module PUBLIC
    "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
    "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
<module name="Checker">
  <module name="TreeWalker">
    <module
name="com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck">
      <property name="max" value="80"/>
      <property name="ignoreClass" value="false"/>
      <property name="ignoreConstructor" value="false"/>
      <property name="ignoreField" value="false"/>
      <property name="ignoreMethod" value="false"/>
    </module>
  </module>
</module>

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=397080&aid=3044164&group_id=29721

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Checkstyle-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/checkstyle-devel
Loading...