[ checkstyle-Bugs-3575496 ] Fan Out Complexity check should exclude java.lang

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[ checkstyle-Bugs-3575496 ] Fan Out Complexity check should exclude java.lang

SourceForge.net
Bugs item #3575496, was opened at 2012-10-08 07:52
Message generated for change (Tracker Item Submitted) made by vmassol
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=397078&aid=3575496&group_id=29721

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core Framework
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Vincent Massol (vmassol)
Assigned to: Oliver Burn (oburn)
Summary: Fan Out Complexity check should exclude java.lang

Initial Comment:
I see in the code of AbstractClassCouplingCheck that java.lang are meant to be excluded:

        private boolean isSignificant(String aClassName)
        {
            return (aClassName.length() > 0)
                    && !mIgnoredClassNames.contains(aClassName)
                    && !aClassName.startsWith("java.lang.");
        }


However in practice they are not excluded since the class names that are checked do NOT have their full package name computed.
For example "java.lang.Class" gets counted since only "Class" is passed to isSignificant().

This is a a big issue...

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=397078&aid=3575496&group_id=29721

------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
_______________________________________________
Checkstyle-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/checkstyle-devel
Loading...