Re: [Checkstyle-commits] SF.net SVN: checkstyle:[2458] trunk/checkstyle

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [Checkstyle-commits] SF.net SVN: checkstyle:[2458] trunk/checkstyle

Lars Kühne-3
On Sun, Mar 8, 2009 at 5:21 AM, <oburn> wrote:
+    <!-- had problems with following using lastest JDK, where this hung -->
    <native2ascii src="src/checkstyle"
                  dest="${checkstyle.dest}"
                  encoding="EUC-JP"
                  includes="**/*_ja.properties" />


Hi Oliver,

the native2ascii approach was OK back then to simplify maintenance of the resource bundles for native speakers. But now we have competent IDEs or resource bundle editor plugins like eclipse-rbe that do the native2ascii escaping on the fly, while saving the file. You never see the \u stuff while editing ascii escaped resource bundle entries.

If the current approach hangs the build, isn't it time we ditch native2ascii and just check in the encoded files?

Cheers,
Lars

PS: Sorry if you get this message twice, it seems my first reply didn't get through

------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
Checkstyle-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/checkstyle-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Checkstyle-commits] SF.net SVN: checkstyle:[2458] trunk/checkstyle

Oliver Burn
I found that if I run the build from the command line (Cygwin or cmd.exe) using the latest JDK6, the build will hang on this step. Using a different version works.

I do not mind if this step is removed if you believe it is no longer necessary. I have no way of validating the resulting files (as I cannot read Japanese:-)

On Tue, Mar 10, 2009 at 07:06, Lars Kühne <[hidden email]> wrote:
On Sun, Mar 8, 2009 at 5:21 AM, <oburn> wrote:
+    <!-- had problems with following using lastest JDK, where this hung -->
    <native2ascii src="src/checkstyle"
                  dest="${checkstyle.dest}"
                  encoding="EUC-JP"
                  includes="**/*_ja.properties" />


Hi Oliver,

the native2ascii approach was OK back then to simplify maintenance of the resource bundles for native speakers. But now we have competent IDEs or resource bundle editor plugins like eclipse-rbe that do the native2ascii escaping on the fly, while saving the file. You never see the \u stuff while editing ascii escaped resource bundle entries.

If the current approach hangs the build, isn't it time we ditch native2ascii and just check in the encoded files?

Cheers,
Lars

PS: Sorry if you get this message twice, it seems my first reply didn't get through


------------------------------------------------------------------------------

_______________________________________________
Checkstyle-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/checkstyle-devel