Consistency issues with Checkstyle

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Consistency issues with Checkstyle

Jonathan Reeve
I'm having a problem with Checkstyle not returning consistent results. Here's an example. I ran Checkstyle from the command line several times in quick succession. The output from last two times follows. The code being checked hadn't changed, and nor had the rules file.

O:\temp>java -jar checkstyle-5.2-all.jar -c plc-checkstyle-rules.xml -r EditWithOfficeButtons.java
Starting audit...
O:\temp\EditWithOfficeButtons.java:0: Got an exception - java.lang.RuntimeException: Unable to get class information for UIException.
O:\temp\EditWithOfficeButtons.java:32: Missing a Javadoc comment.
O:\temp\EditWithOfficeButtons.java:33: member def modifier at indentation level 8 not at correct indentation, 4
O:\temp\EditWithOfficeButtons.java:33:1: File contains tab characters (this is the first instance).
O:\temp\EditWithOfficeButtons.java:38:13: '{' should be on the previous line.
O:\temp\EditWithOfficeButtons.java:124: Line is longer than 150 characters.
Audit done.

O:\temp>java -jar checkstyle-5.2-all.jar -c plc-checkstyle-rules.xml -r EditWithOfficeButtons.java
Starting audit...
O:\temp\EditWithOfficeButtons.java:0: Got an exception - java.lang.RuntimeException: Unable to get class information for UIException.
O:\temp\EditWithOfficeButtons.java:32: Missing a Javadoc comment.
O:\temp\EditWithOfficeButtons.java:33: member def modifier at indentation level 8 not at correct indentation, 4
O:\temp\EditWithOfficeButtons.java:33:1: File contains tab characters (this is the first instance).
O:\temp\EditWithOfficeButtons.java:37: method def modifier at indentation level 9 not at correct indentation, 4
O:\temp\EditWithOfficeButtons.java:37:10: Missing a Javadoc comment.
O:\temp\EditWithOfficeButtons.java:37:37: Parameter event should be final.
O:\temp\EditWithOfficeButtons.java:38: method def lcurly at indentation level 12 not at correct indentation, 4
O:\temp\EditWithOfficeButtons.java:38:13: '{' should be on the previous line.
O:\temp\EditWithOfficeButtons.java:39: method def child at indentation level 17 not at correct indentation, 8
O:\temp\EditWithOfficeButtons.java:40: method def child at indentation level 17 not at correct indentation, 8
O:\temp\EditWithOfficeButtons.java:42: method def child at indentation level 17 not at correct indentation, 8
O:\temp\EditWithOfficeButtons.java:43: method def child at indentation level 17 not at correct indentation, 8
O:\temp\EditWithOfficeButtons.java:45: method def rcurly at indentation level 12 not at correct indentation, 4
O:\temp\EditWithOfficeButtons.java:124: Line is longer than 150 characters.
Audit done.


Is this a bug, or am I misunderstanding something?


Jonathan Reeve
Technical Lead
Practical Law Company
19 Hatfields
London SE1 8DJ
T  +44 (0)20 7202 7301
E  [hidden email]
W  http://www.practicallaw.com/






Practical Law Company has been named as the 2009 InnovAction Award Winner for creating efficiency for business lawyers.


This e-mail from Practical Law Company (http://www.practicallaw.com) is subject to our terms of use (http://www.practicallaw.com/9-103-0884). Information about our companies: Practical Law Company Limited. Registered in England and Wales. Registered Number: 02889191. Registered Office: 19 Hatfields, London SE1 8DJ. Telephone: +44(0)20 7202 1200.
Practical Law Company, Inc. Incorporated in Delaware, USA.  Corporate Office: 747 Third Avenue, 36th Floor, New York, NY 10017. Telephone: +1(646) 562-3400.

------------------------------------------------------------------------------
Download new Adobe(R) Flash(R) Builder(TM) 4
The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly
Flex(R) Builder(TM)) enable the development of rich applications that run
across multiple browsers and platforms. Download your free trials today!
http://p.sf.net/sfu/adobe-dev2dev
_______________________________________________
Checkstyle-user mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/checkstyle-user
Reply | Threaded
Open this post in threaded view
|

Re: Consistency issues with Checkstyle

Oliver Burn
Interesting - never seen that.

Can you send me a copy of the files:
  • plc-checkstyle-rules.xml
  • EditWithOfficeButtons.java
Then I can attempt to reproduce.

Cheers,
Oliver

On Fri, Oct 15, 2010 at 21:01, Jonathan Reeve <[hidden email]> wrote:
I'm having a problem with Checkstyle not returning consistent results. Here's an example. I ran Checkstyle from the command line several times in quick succession. The output from last two times follows. The code being checked hadn't changed, and nor had the rules file.

O:\temp>java -jar checkstyle-5.2-all.jar -c plc-checkstyle-rules.xml -r EditWithOfficeButtons.java
Starting audit...
O:\temp\EditWithOfficeButtons.java:0: Got an exception - java.lang.RuntimeException: Unable to get class information for UIException.
O:\temp\EditWithOfficeButtons.java:32: Missing a Javadoc comment.
O:\temp\EditWithOfficeButtons.java:33: member def modifier at indentation level 8 not at correct indentation, 4
O:\temp\EditWithOfficeButtons.java:33:1: File contains tab characters (this is the first instance).
O:\temp\EditWithOfficeButtons.java:38:13: '{' should be on the previous line.
O:\temp\EditWithOfficeButtons.java:124: Line is longer than 150 characters.
Audit done.

O:\temp>java -jar checkstyle-5.2-all.jar -c plc-checkstyle-rules.xml -r EditWithOfficeButtons.java
Starting audit...
O:\temp\EditWithOfficeButtons.java:0: Got an exception - java.lang.RuntimeException: Unable to get class information for UIException.
O:\temp\EditWithOfficeButtons.java:32: Missing a Javadoc comment.
O:\temp\EditWithOfficeButtons.java:33: member def modifier at indentation level 8 not at correct indentation, 4
O:\temp\EditWithOfficeButtons.java:33:1: File contains tab characters (this is the first instance).
O:\temp\EditWithOfficeButtons.java:37: method def modifier at indentation level 9 not at correct indentation, 4
O:\temp\EditWithOfficeButtons.java:37:10: Missing a Javadoc comment.
O:\temp\EditWithOfficeButtons.java:37:37: Parameter event should be final.
O:\temp\EditWithOfficeButtons.java:38: method def lcurly at indentation level 12 not at correct indentation, 4
O:\temp\EditWithOfficeButtons.java:38:13: '{' should be on the previous line.
O:\temp\EditWithOfficeButtons.java:39: method def child at indentation level 17 not at correct indentation, 8
O:\temp\EditWithOfficeButtons.java:40: method def child at indentation level 17 not at correct indentation, 8
O:\temp\EditWithOfficeButtons.java:42: method def child at indentation level 17 not at correct indentation, 8
O:\temp\EditWithOfficeButtons.java:43: method def child at indentation level 17 not at correct indentation, 8
O:\temp\EditWithOfficeButtons.java:45: method def rcurly at indentation level 12 not at correct indentation, 4
O:\temp\EditWithOfficeButtons.java:124: Line is longer than 150 characters.
Audit done.


Is this a bug, or am I misunderstanding something?


Jonathan Reeve
Technical Lead
Practical Law Company
19 Hatfields
London SE1 8DJ
T  +44 (0)20 7202 7301
E  [hidden email]
W  http://www.practicallaw.com/






Practical Law Company has been named as the 2009 InnovAction Award Winner for creating efficiency for business lawyers.


This e-mail from Practical Law Company (http://www.practicallaw.com) is subject to our terms of use (http://www.practicallaw.com/9-103-0884). Information about our companies: Practical Law Company Limited. Registered in England and Wales. Registered Number: 02889191. Registered Office: 19 Hatfields, London SE1 8DJ. Telephone: +44(0)20 7202 1200.
Practical Law Company, Inc. Incorporated in Delaware, USA.  Corporate Office: 747 Third Avenue, 36th Floor, New York, NY 10017. Telephone: +1(646) 562-3400.

------------------------------------------------------------------------------
Download new Adobe(R) Flash(R) Builder(TM) 4
The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly
Flex(R) Builder(TM)) enable the development of rich applications that run
across multiple browsers and platforms. Download your free trials today!
http://p.sf.net/sfu/adobe-dev2dev
_______________________________________________
Checkstyle-user mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/checkstyle-user


------------------------------------------------------------------------------
Download new Adobe(R) Flash(R) Builder(TM) 4
The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly
Flex(R) Builder(TM)) enable the development of rich applications that run
across multiple browsers and platforms. Download your free trials today!
http://p.sf.net/sfu/adobe-dev2dev
_______________________________________________
Checkstyle-user mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/checkstyle-user